-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACS-8434: progress component #9960
Conversation
Quality Gate passedIssues Measures |
</ng-container> | ||
|
||
<ng-container *ngSwitchCase="'spinner'"> | ||
<mat-progress-spinner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add [diameter]
parameter to be able to change the size?
And may be it make sense to add any class or wrapper not to touch mat-selectors and change styles
For example, here we have to use wrapper to make spinner in the center of the box
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
adf-progress
component that can render bars and spinnersDoes this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: