Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-5898] prevent custom task filters from always sending due after date #8847

Conversation

g-jaskowski
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACS-5898

  • setDueAfterFilter with moment library always sent Invalid Date, when Due After Filter parameter was null or initialized with empty quotes, after change to date-fns, the date in proper format was always sent, even with empty filter field, which resulted in not listing tasks without due date
  • Custom filters form parameters were initialized with empty brackets, which resulted in wrong query parameters before clicking reset button or updating every parameter in form

What is the new behaviour?

  • Custom task filters query does not include due after date when corresponding filter is empty
  • Form parameters are not initialized with any value

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

…te, build custom filters form without initial values
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DenysVuika DenysVuika merged commit 87e5727 into develop Aug 24, 2023
34 checks passed
@DenysVuika DenysVuika deleted the ACS-5898-ADF-task-list-not-working-correctly-for-Filter-fields branch August 24, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants