Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APPS-2128] remove moment dependency from task-list.component.ts #8838

Merged
merged 1 commit into from
Aug 29, 2023
Merged

[APPS-2128] remove moment dependency from task-list.component.ts #8838

merged 1 commit into from
Aug 29, 2023

Conversation

jatin2008
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
moment depedency is present in task-list.component.ts

What is the new behaviour?
removed moment dependency from task-list.component.ts

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@jatin2008 jatin2008 marked this pull request as ready for review August 23, 2023 05:17
@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DenysVuika DenysVuika merged commit 657711e into develop Aug 29, 2023
34 checks passed
@DenysVuika DenysVuika deleted the dev-jatin-APPS-2128 branch August 29, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenysVuika DenysVuika DenysVuika approved these changes

@AleksanderSklorz AleksanderSklorz AleksanderSklorz approved these changes

@eromano eromano Awaiting requested review from eromano eromano is a code owner

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

Assignees
No one assigned
Labels
A/N BDU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jatin2008 @DenysVuika @AleksanderSklorz