[ACS-5505] - Custom aspect properties are not updated when removing last existing property #8828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikiwanekhyland
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
dominikiwanekhyland
requested review from
akashrathod28,
swapnil-verma-gl,
MichalKinas,
MateuszHY and
AleksanderSklorz
MichalKinas
reviewed
Aug 17, 2023
...-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.ts
Show resolved
Hide resolved
AleksanderSklorz
approved these changes
Aug 17, 2023
dominikiwanekhyland
force-pushed
the
ACS-5505-acs-custome-aspect-properties-for-folder-are-not-reset-shown-until-we-reopen-the-details-component
branch
from
98f454a
to
c1d8f14
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
dominikiwanekhyland
deleted the
ACS-5505-acs-custome-aspect-properties-for-folder-are-not-reset-shown-until-we-reopen-the-details-component
branch
jatin2008
pushed a commit
that referenced
this pull request
Aug 28, 2023
jatin2008
pushed a commit
that referenced
this pull request
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ast existing property
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
When custom aspect has only one property and you remove it, node is not updated. It is coming back from backend without 'properties' field and it wasn't merged into current node object.
What is the new behaviour?
Custom property is always updated.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: