[ACA-4712] changes required to disallow using important for styles in aca #8785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksanderSklorz
requested review from
nikita-web-ua,
swapnil-verma-gl,
MichalKinas and
g-jaskowski
AleksanderSklorz
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -31,7 +31,7 @@ | |||
| [style.display]="isExpiryDateToggleChecked ? 'block' : 'none'" | |||
| data-automation-id="adf-slide-toggle-checked" | |||
| class="adf-share-link__date-time-container"> | |||
| <mat-form-field class="adf-full-width adf-float-label" floatLabel='always'> | |||
| <mat-form-field class="adf-full-width adf-float-label" floatLabel='never'> | |||
There was a problem hiding this comment.
For anyone who will be looking at that PR in the future. I changed it because of strange workaround applied in that file and removed:
Somebody was hiding labels using css styles instead of mat form API. So then they were not visible in that modal:
DenysVuika
approved these changes
Jul 25, 2023
AleksanderSklorz
deleted the
ACA-4712-Changes-required-to-disallow-using-important-for-styles-in-aca
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACA-4712
What is the new behaviour?
Changes required to remove usages of !important from ACA.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
ACA PR: Alfresco/alfresco-content-app#3368