-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AAE-12065] Add isDefault flag to dropdown #8771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens if isDefault is not present in the JSON because is a form previously created?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add a unit that cover this scenario?
7c4ed5d
to
6eacb40
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
No need for this changes anymore. https://alfresco.atlassian.net/browse/AAE-12065?focusedCommentId=1192290 |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
If dropdown field had the same id as the
DEFAULT_OPTION.id
, it would be taken as the default optionhttps://alfresco.atlassian.net/browse/AAE-12065
https://github.com/Alfresco/alfresco-apps/pull/5894
What is the new behaviour?
Add
isDefault
flag to allow users to use theDEFAULT_OPTION.id
as an id, without making such an option the default optionIs compatible with JSON forms previously created
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: