-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACS-5480] Bug Fix for multiple process/task filters #8757
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eromano
requested changes
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing unit test
SheenaMalhotra182
requested review from
popovicsandras and
DenysVuika
as code owners
July 15, 2023 06:52
rbahirsheth
approved these changes
Jul 15, 2023
SheenaMalhotra182
force-pushed
the
ACS-5480
branch
from
July 15, 2023 14:35
5e0cffb
to
07b454c
Compare
DenysVuika
reviewed
Jul 17, 2023
lib/process-services/src/lib/task-list/services/task-filter.service.spec.ts
Outdated
Show resolved
Hide resolved
DenysVuika
approved these changes
Jul 17, 2023
MichalKinas
reviewed
Jul 17, 2023
lib/process-services/src/lib/process-list/services/process-filter.service.ts
Show resolved
Hide resolved
lib/process-services/src/lib/process-list/services/process-filter.service.ts
Show resolved
Hide resolved
SheenaMalhotra182
force-pushed
the
ACS-5480
branch
from
July 19, 2023 14:06
20386d2
to
839c5f8
Compare
MichalKinas
approved these changes
Jul 20, 2023
SheenaMalhotra182
force-pushed
the
ACS-5480
branch
from
July 20, 2023 12:10
734bb4e
to
1895d51
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
eromano
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Multiple process or task filters were rendering
What is the new behaviour?
added a check before pushing the filters so that no repetitive filter names are pushed.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://alfresco.atlassian.net/browse/ACS-5480