[ACS-5400] Fix incomplete string escaping #8721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-web-ua
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
AleksanderSklorz
approved these changes
Jun 29, 2023
DenysVuika
requested changes
Jun 30, 2023
| @@ -109,7 +109,7 @@ function getCommits(options: DiffOptions): Array<Commit> { | |||
| let log = shell.exec(command, { cwd: options.dir, silent: true }).toString(); | |||
|
|
|||
| // https://stackoverflow.com/a/13928240/14644447 | |||
| log = log.trim().replace(/"/gm, '\\"').replace(/\^@\^/gm, '"'); | |||
| log = JSON.stringify(log.trim()).slice(1, -1).replace(/\^@\^/gm, '"'); | |||
There was a problem hiding this comment.
i'm not sure it is going to work as log is not an object so you can't stringify it
There was a problem hiding this comment.
log is a string, we use JSON.stringity to escape the quotes
There was a problem hiding this comment.
did you test the changelog command? does it produce the expected output?
There was a problem hiding this comment.
Added a fix, now works as expected
nikita-web-ua
force-pushed
the
dev-mmaliarchuk/ACS-5400-Incomplete-string-escaping-or-encoding
branch
from
29d3e71
to
d295e82
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
MichalKinas
approved these changes
Jul 25, 2023
DenysVuika
approved these changes
Jul 29, 2023
DenysVuika
deleted the
dev-mmaliarchuk/ACS-5400-Incomplete-string-escaping-or-encoding
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACS-5400
What is the new behaviour?
Fixed incomplete string escaping
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: