[ACS-4985] Created an advanced date range filter for search #8714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swapnil-verma-gl
requested review from
nikita-web-ua,
MichalKinas and
AleksanderSklorz
swapnil-verma-gl
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
swapnil-verma-gl
changed the title
docs/content-services/components/search-date-range-advanced-tabbed.component.md
Outdated
Show resolved
Hide resolved
docs/content-services/components/search-date-range-advanced-tabbed.component.md
Outdated
Show resolved
Hide resolved
docs/content-services/components/search-date-range-advanced-tabbed.component.md
Outdated
Show resolved
Hide resolved
docs/content-services/components/search-date-range-advanced-tabbed.component.md
Outdated
Show resolved
Hide resolved
docs/content-services/components/search-date-range-advanced.component.md
Outdated
Show resolved
Hide resolved
docs/content-services/components/search-date-range-advanced.component.md
Outdated
Show resolved
Hide resolved
docs/content-services/components/search-date-range-advanced.component.md
Outdated
Show resolved
Hide resolved
MichalKinas
reviewed
Jun 28, 2023
docs/content-services/components/search-date-range-advanced-tabbed.component.md
Outdated
Show resolved
Hide resolved
docs/content-services/components/search-date-range-advanced-tabbed.component.md
Outdated
Show resolved
Hide resolved
docs/content-services/components/search-date-range-advanced-tabbed.component.md
Outdated
Show resolved
Hide resolved
docs/content-services/components/search-date-range-advanced.component.md
Outdated
Show resolved
Hide resolved
...omponents/search-date-range-advanced-tabbed/search-date-range-advanced-tabbed.component.scss
Outdated
Show resolved
Hide resolved
...onents/search-date-range-advanced-tabbed/search-date-range-advanced-tabbed.component.spec.ts
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| hasValidValue(): boolean { | ||
| return !Object.values(this.tabsValidity).some((valid) => !valid); |
There was a problem hiding this comment.
This looks like a bit weird negation, I think it would be more readable if you use .every and check if each is valid instead of checking if some is invalid and negating it
There was a problem hiding this comment.
Updated the code to use .every() instead. This looks much better now, thanks!!
| this.startValue = { | ||
| ...this.startValue | ||
| }; | ||
| setTimeout(() => { |
There was a problem hiding this comment.
Why is there timeout required here?
There was a problem hiding this comment.
This was leftover code that was not needed. Removed setTImeout()
...lib/search/components/search-filter-chips/search-widget-chip/search-widget-chip.component.ts
Outdated
Show resolved
Hide resolved
docs/content-services/components/search-filter-tabbed.component.md
Outdated
Show resolved
Hide resolved
docs/content-services/components/search-filter-tabbed.component.md
Outdated
Show resolved
Hide resolved
docs/content-services/components/search-filter-tabbed.component.md
Outdated
Show resolved
Hide resolved
docs/content-services/components/search-filter-tabbed.component.md
Outdated
Show resolved
Hide resolved
...omponents/search-date-range-advanced-tabbed/search-date-range-advanced-tabbed.component.html
Outdated
Show resolved
Hide resolved
...onents/search-date-range-advanced-tabbed/search-date-range-advanced-tabbed.component.spec.ts
Outdated
Show resolved
Hide resolved
...onents/search-date-range-advanced-tabbed/search-date-range-advanced-tabbed.component.spec.ts
Outdated
Show resolved
Hide resolved
...onents/search-date-range-advanced-tabbed/search-date-range-advanced-tabbed.component.spec.ts
Outdated
Show resolved
Hide resolved
...onents/search-date-range-advanced-tabbed/search-date-range-advanced-tabbed.component.spec.ts
Outdated
Show resolved
Hide resolved
...onents/search-date-range-advanced-tabbed/search-date-range-advanced-tabbed.component.spec.ts
Outdated
Show resolved
Hide resolved
...onents/search-date-range-advanced-tabbed/search-date-range-advanced-tabbed.component.spec.ts
Outdated
Show resolved
Hide resolved
...onents/search-date-range-advanced-tabbed/search-date-range-advanced-tabbed.component.spec.ts
Outdated
Show resolved
Hide resolved
…e when setting invalid date error on between date form fields
… 'Between' options use the start date to end date query format
…ng some numbers in the 'In the last' input field would clear out the field
…d width of the side filters panel in demo-shell search results window.
…s for e2e test cases
swapnil-verma-gl
force-pushed
the
dev-swapnil-ACA-4985-created-modified-facet
branch
from
5e5130f
to
1e6b351
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
swapnil-verma-gl
restored the
dev-swapnil-ACA-4985-created-modified-facet
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
There is no advances date range filter for search
What is the new behaviour?
Created a new advanced date range filter for search. Also created a tabbed component for filtering on created as well as modified date. Refer ACS-4985 for more
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: