Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AAE-15436] Fix init-aae-env await for apps to be deployed #8697

Merged
merged 2 commits into from
Jun 23, 2023
Merged

[AAE-15436] Fix init-aae-env await for apps to be deployed #8697

merged 2 commits into from
Jun 23, 2023

Conversation

alep85
Copy link
Contributor

@alep85 alep85 commented Jun 23, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/AAE-15436

What is the new behaviour?

  • Properly awaits deploy of application before moving on to the next one.
  • Add logs to better track deploy flow.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DenysVuika DenysVuika merged commit 74fd03b into develop Jun 23, 2023
34 checks passed
@DenysVuika DenysVuika deleted the dev-alepore-AAE-15436 branch June 23, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenysVuika DenysVuika DenysVuika approved these changes

@andrea-ligios andrea-ligios andrea-ligios approved these changes

@DiogoABastos DiogoABastos DiogoABastos approved these changes

@mauriziovitale mauriziovitale Awaiting requested review from mauriziovitale

@eromano eromano Awaiting requested review from eromano eromano is a code owner

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alep85 @DenysVuika @andrea-ligios @DiogoABastos