[ACS-8823] Viewer - do not show non responsive dialog if blobFile was provided #10247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-web-ua
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
|
DenysVuika
approved these changes
Sep 25, 2024
swapnil-verma-gl
approved these changes
Sep 26, 2024
dominikiwanekhyland
approved these changes
Sep 26, 2024
jacekpluta
approved these changes
Sep 27, 2024
akashrathod28
deleted the
dev-mmaliarchuk/ACS-8823-The-file-attached-to-the-completed-task-cannot-be-viewed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Non responsive download prompt dialog will pop up even if the viewer was rendered properly using blobFile, in case if urlFile was not provided.
What is the new behaviour?
The "Download Prompt Dialog" will only appear if neither blobFile nor urlFile were specified.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: