Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAE-25409 Fix custom outcome button not starting a process if used in start process form #10232

Conversation

wojd0
Copy link
Contributor

@wojd0 wojd0 commented Sep 19, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://hyland.atlassian.net/browse/AAE-25409
Custom outcome buttons if used in a start process form weren't doing anything when clicked.

What is the new behaviour?

Custom outcome buttons correctly start a new process and pass outcome name to process implementation (mapping).

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@wojd0 wojd0 force-pushed the fix/AAE-25409-custom-outcomes-buttons-in-start-process-form-not-starting-process branch from 3b7f3b4 to 789ace5 Compare September 20, 2024 08:44
@VitoAlbano VitoAlbano force-pushed the fix/AAE-25409-custom-outcomes-buttons-in-start-process-form-not-starting-process branch from 789ace5 to f6a8568 Compare September 20, 2024 09:16
@wojd0 wojd0 marked this pull request as ready for review September 20, 2024 12:04
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@wojd0 wojd0 merged commit 8144006 into develop Sep 20, 2024
17 of 18 checks passed
@wojd0 wojd0 deleted the fix/AAE-25409-custom-outcomes-buttons-in-start-process-form-not-starting-process branch September 20, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants