[ACS-8806] refactor process comments #10230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-jaskowski
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
DenysVuika
approved these changes
Sep 18, 2024
g-jaskowski
force-pushed
the
ACS-8806-Refactor-process-comments-component-in-ADF
branch
from
b1f2813
to
7298fc6
Compare
MichalKinas
reviewed
Sep 18, 2024
lib/process-services/src/lib/process-list/components/process-list/process-list.component.ts
Outdated
Show resolved
Hide resolved
| @@ -61,6 +73,9 @@ export const PRESET_KEY = 'adf-task-list.presets'; | |||
| styleUrls: ['./task-list.component.css'] | |||
| }) | |||
| export class TaskListComponent extends DataTableSchema implements OnChanges, AfterContentInit, PaginatedComponent, OnDestroy, OnInit { | |||
| @ViewChild(DataTableComponent) | |||
There was a problem hiding this comment.
Why do we need this change?
There was a problem hiding this comment.
Reverted those changes, as I've found a possibly better solution
dominikiwanekhyland
approved these changes
Sep 18, 2024
|
swapnil-verma-gl
approved these changes
Sep 19, 2024
MichalKinas
approved these changes
Sep 19, 2024
g-jaskowski
deleted the
ACS-8806-Refactor-process-comments-component-in-ADF
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/ACS-8806
What is the new behaviour?
Process comments component reuses comments component instead of duplicated implementation.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: