Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACS-8201] Knowledge Retrieval - getting AI response for one or more selected files #10229

Merged
merged 20 commits into from
Sep 19, 2024
Merged

[ACS-8201] Knowledge Retrieval - getting AI response for one or more selected files #10229

merged 20 commits into from
Sep 19, 2024

Conversation

jacekpluta
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/ACS-8201

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

AleksanderSklorz and others added 15 commits September 18, 2024 13:34
@AleksanderSklorz @jacekpluta
[ACS-8202] basic flow getting ai response for one or more selected fi…
84bacd2 
…les (#9944)

* ACS-8202 Getting list of agents

* ACS-8202 Mocked agents, used base api from hxi connector

* ACS-8202 Search Ai service

* ACS-8202 Small correction and mocked data

* ACS-8202 Renamed variable

* ACS-8202 Added documentation

* ACS-8202 Addressed PR comments

* ACS-8202 Type change

* ACS-8202 Reverted unwatend change

* ACS-8202 Reverted unwanted change
@AleksanderSklorz @jacekpluta
ACS-8201 Small correction after rebasing with Angular 15
1cd82e3
@AleksanderSklorz @jacekpluta
[ACS-8398] Unit tests for agents and search ai (#9974)
0e64e52 
* ACS-8398 Unit tests for search ai api and agents api

* ACS-8398 Unit tests for getAnswer function from SearchAiApi, corrections for unit tests for SearchAiApi and AgentsApi

* ACS-8398 Unit tests for SearchAiService and AgentService
@jacekpluta
[ACS-8210] Agent basic details popup (#9956)
d0805fe
@jacekpluta
[ACS-8573] Allow user to ask question without file selection
e349361
@jacekpluta
[ACS-8312] Display warning about losing response (#10059)
c63713d 
* [ACS-8312] Display warning about losing response

* [ACS-8312] Display warning about losing response - fixes
@jacekpluta
[ACS-8432] Sending all file types to HX instead of only the text file…
edadc33 
… types (#10087)
@AleksanderSklorz @jacekpluta
ACS-8201 Fixed issues after rebase
7091ad8
@jacekpluta
[ACS-8588] Navigation is triggered twice when leaving Knowledge Retri…
72ad331 
…eval page (#10132)

* [ACS-8588] Navigation is triggered twice when leaving Knowledge Retrieval page

* [ACS-8588] Navigation is triggered twice when leaving Knowledge Retrieval page - review fixes

* [ACS-8588] Navigation is triggered twice when leaving Knowledge Retrieval page - review fixes 2
@jacekpluta
[ACS-8399] Integrate all changes with backend (#10163)
0ae3cd0
@jacekpluta
Answers endpoint fix (#10176)
78d95df
@AleksanderSklorz @jacekpluta
[ACS-8664] generic question redirection to hx insight (#10174)
f091c86 
* ACS-8664 Loading HX insight url

* ACS-8664 Added documentation for loading config of Knowledge Retrieval

* ACS-8664 Unit tests

* ACS-8664 Fixed unit tests

* ACS-8664 Fixed unit tests after rebase

* ACS-8664 Addressed comment
@AleksanderSklorz @jacekpluta
ACS-8201 Fixed issues after rebase
6bced95
@jacekpluta
[ACS-8695] Getting Agent avatar (#10189)
acb162f 
* [ACS-8695] Getting Agent avatar

* [ACS-8695] Getting Agent avatar - on image load error
@jacekpluta
[ACS-8695] Getting Agent avatar - removed getAgentAvatar call (#10209)
16da78f
MichalKinas
MichalKinas approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@MichalKinas MichalKinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of smaller comments but overall it LGTM

docs/content-services/services/agent.service.md Outdated Show resolved Hide resolved
docs/content-services/services/search-ai.service.md Outdated Show resolved Hide resolved
docs/versionIndex.md Outdated Show resolved Hide resolved
docs/content-services/services/agent.service.md Show resolved Hide resolved
lib/core/src/lib/dialogs/unsaved-changes-dialog/unsaved-changes-dialog.component.ts Outdated Show resolved Hide resolved
lib/js-api/src/api/content-rest-api/api/agents.api.ts Show resolved Hide resolved
@AleksanderSklorz AleksanderSklorz changed the title [Acs 8201] Knowledge Retrieval - getting AI response for one or more selected files [ACS-8201] Knowledge Retrieval - getting AI response for one or more selected files Sep 19, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jacekpluta jacekpluta merged commit 797b800 into develop Sep 19, 2024
17 checks passed
@jacekpluta jacekpluta deleted the ACS-8201-Knowledge-retrieval branch September 19, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichalKinas MichalKinas MichalKinas approved these changes

@AleksanderSklorz AleksanderSklorz AleksanderSklorz approved these changes

@eromano eromano Awaiting requested review from eromano eromano is a code owner

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

@DenysVuika DenysVuika Awaiting requested review from DenysVuika DenysVuika is a code owner

Assignees
No one assigned
Labels
A/N BDU AI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacekpluta @MichalKinas @AleksanderSklorz