AAE-25888 Offset SearchTextInput expansion based on search icon width #10213
Conversation
wojd0
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
| @@ -197,15 +197,19 @@ export class SearchTextInputComponent implements OnInit, OnDestroy { | |||
| return this.autocomplete ? 'on' : 'off'; | |||
| } | |||
|
|
|||
| get searchIconOffset(): string { | |||
| return this.expandable ? '48px' : '0px'; | |||
There was a problem hiding this comment.
why do you presume the icon is 48px all the time? is this hardcoded somewhere else?
There was a problem hiding this comment.
it's the combined padding and width coming from angular material's .mat-mdc-form-field-icon-suffix class
There was a problem hiding this comment.
Wouldn't this mean that, if something changes in the styles we will have a problem here? isn't there a more flexible approach to this issue?
VitoAlbano
force-pushed
the
fix/AAE-25888-search-text-input-transform-offset
branch
from
ea7174b
to
0bfc43a
Compare
| @@ -197,15 +197,19 @@ export class SearchTextInputComponent implements OnInit, OnDestroy { | |||
| return this.autocomplete ? 'on' : 'off'; | |||
| } | |||
|
|
|||
| get searchIconOffset(): string { | |||
| return this.expandable ? '48px' : '0px'; | |||
There was a problem hiding this comment.
Wouldn't this mean that, if something changes in the styles we will have a problem here? isn't there a more flexible approach to this issue?
wojd0
force-pushed
the
fix/AAE-25888-search-text-input-transform-offset
branch
2 times, most recently
from
607331b
to
55468ec
Compare
| &-search-button-inactive { | ||
| margin-left: -48px; | ||
| } | ||
|
|
There was a problem hiding this comment.
this approach using a separate class for the inactive search button state should be more customization-friendly
VitoAlbano
force-pushed
the
fix/AAE-25888-search-text-input-transform-offset
branch
from
55468ec
to
cd96e26
Compare
|
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/AAE-25888
Expandable search text input offset by approximate not full value to compensate for the search icon's width.
What is the new behaviour?
Expandable search text input offset by 100% minus actual search icon width.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: