Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ng16 migration #10041

Closed
wants to merge 23 commits into from
Closed

Ng16 migration #10041

wants to merge 23 commits into from

Conversation

VitoAlbano
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@VitoAlbano VitoAlbano force-pushed the ng16-migration branch 3 times, most recently from e7bf673 to 8d49047 Compare August 5, 2024 12:59
@VitoAlbano VitoAlbano force-pushed the ng16-migration branch 7 times, most recently from 9406449 to ff543ac Compare August 8, 2024 14:47
@wojd0 wojd0 force-pushed the ng16-migration branch 4 times, most recently from 230f109 to a06f86f Compare August 13, 2024 06:41
@VitoAlbano VitoAlbano force-pushed the ng16-migration branch 9 times, most recently from 84026c2 to 6d72d2b Compare August 19, 2024 22:17
@VitoAlbano
NG-16 - migration step 1
c18a31a 
(cherry picked from commit c521a90)
VitoAlbano and others added 22 commits August 19, 2024 23:19
@VitoAlbano
NG16 - fixed the builds
d1d710a 
(cherry picked from commit 3011a67)
@VitoAlbano
[ci:force] - Added some changes and fixed lock
8f7aea6 
(cherry picked from commit 7efd4a5)
@VitoAlbano
[MIGRATION] - added reference to @types also to general node_modules
3875da6 
(cherry picked from commit fcf848e)
@VitoAlbano
Readded js-api bundle as it's needed for testing package for now
55ad14e 
(cherry picked from commit 92823bd)
@VitoAlbano
[MIGRATION] - Improving the testing build to avoid having to bundle a…
b5b9b88 
…lso the js-api

(cherry picked from commit cf175c6)
@VitoAlbano
[MIGRATION] - Fixed lint errors for empty function
3e2fd36 
(cherry picked from commit 1c339a9)
@VitoAlbano
[MIGRATION] - Solving a funny comment issue
5d0b1ce 
(cherry picked from commit 3e00a1f)
@VitoAlbano
[MIGRATION] - Solving a funny comment issue part 2
e9e4796 
(cherry picked from commit 530b2be)
@VitoAlbano
[MIGRATION] - Reverting js-api bundle remove
dd777c3 
(cherry picked from commit ece00f7)
@VitoAlbano
[MIGRATION] - Changed command for affected libs
3738b93 
(cherry picked from commit 8ad83a5)
@VitoAlbano
[MIGRATION] - I forgot npx
15ec8dc 
(cherry picked from commit a5f6210)
@VitoAlbano
[MIGRATION] - Problem on cli when used - probably misconfiguration
951e15a 
(cherry picked from commit cff291b)
@VitoAlbano
[MIGRATION] - Problem on cli when used - probably misconfiguration
c17ec9b 
(cherry picked from commit 8508dfe)
@VitoAlbano
[MIGRATION] - Are we able to run a test? let's see
3a756c0 
(cherry picked from commit 809808d)
@VitoAlbano
[MIGRATION] - Launched nx repair
6bc89e4 
(cherry picked from commit 1e877dd)
@VitoAlbano
[MIGRATION] - Rebased and added a comment to check why script is failing
0f7e94a 
(cherry picked from commit 02809b6)
@VitoAlbano
[MIGRATION] - Project file restored
b771f06 
(cherry picked from commit 75119fd)
@VitoAlbano
[MIGRATION] - Fixed outdated deps
1b1df0d 
(cherry picked from commit 960ae2f)
@VitoAlbano
[MIGRATION] - Removed wrong comment from e2e
db87c31 
(cherry picked from commit 8344c98)
@wojd0 @VitoAlbano
[MIGRATION] - storybook chips related e2e fails fix, unit alignments
a59e7cb 
(cherry picked from commit 8894962)
@wojd0 @VitoAlbano
[MIGRATION] - change selector for expanded expansion panel content
16c3955 
(cherry picked from commit 57d4699)
@VitoAlbano
[MIGRATION] - Fixed some issues for project and package json
6174a08 
(cherry picked from commit 9710689)
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@VitoAlbano VitoAlbano closed this Aug 19, 2024
@VitoAlbano VitoAlbano deleted the ng16-migration branch August 19, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsan-2019 ehsan-2019 ehsan-2019 approved these changes

@eromano eromano Awaiting requested review from eromano eromano is a code owner

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

@DenysVuika DenysVuika Awaiting requested review from DenysVuika DenysVuika is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VitoAlbano @ehsan-2019 @wojd0