Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACS-8498] aca testing angular 15 toolbar buttons layout is broken #10018

Closed
wants to merge 2 commits into from
Closed

[ACS-8498] aca testing angular 15 toolbar buttons layout is broken #10018

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b85d218
[ACS-8498] [ACA] Testing Angular 15 - Toolbar buttons layout is broken
dominikiwanekhyland Aug 1, 2024
18f5bac
[ACS-8498] [ACA] Testing Angular 15 - Toolbar buttons layout is broken
dominikiwanekhyland Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions lib/core/src/lib/viewer/components/viewer.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
left: 50%;
transform: translateX(-50%);

@media screen and (max-width: 1450px) {
@media screen and (width <= 1450px) {
left: 30%;
}
}
Expand All @@ -70,8 +70,7 @@
@extend .adf-full-screen;

position: relative;
overflow-y: hidden;
overflow-x: hidden;
overflow: hidden;
z-index: 1;
background-color: var(--theme-background-color);
display: flex;
Expand All @@ -94,8 +93,8 @@

display: flex;
flex-direction: row;
overflow: hidden;
overflow-y: auto;
overflow-x: hidden;
position: relative;
}

Expand Down Expand Up @@ -154,4 +153,15 @@
display: flex;
}
}

&-toolbar-actions,
.adf-viewer-close-button {
#{$mat-icon} {
margin-top: -10px;
Copy link
Contributor

@DenysVuika DenysVuika Aug 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a very rude fix, you are just hammering all icons within a button to be in the negative space to cover the layout problem... it's better finding and fixing why those are layouted incorrectly

}

#{$mat-toolbar} {
height: 100%;
}
}
}
Loading