[ACS-8498] aca testing angular 15 toolbar buttons layout is broken #10018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikiwanekhyland
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
dominikiwanekhyland
force-pushed
the
ACS-8498-clone-aca-testing-angular-15-toolbar-buttons-layout-is-broken
branch
from
9bd3a81
to
18f5bac
Compare
|
DenysVuika
requested changes
Aug 1, 2024
| &-toolbar-actions, | ||
| .adf-viewer-close-button { | ||
| #{$mat-icon} { | ||
| margin-top: -10px; |
There was a problem hiding this comment.
this is a very rude fix, you are just hammering all icons within a button to be in the negative space to cover the layout problem... it's better finding and fixing why those are layouted incorrectly
This was referenced Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/ACS-8498
What is the new behaviour?
Fix viewer icons
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: