AAE-23830 Fix chips positioning and filter render logic in process filters #10015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojd0
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
wojd0
force-pushed
the
AAE-23830-fix-labels-and-chips-in-workspace-filters
branch
from
c844099
to
76c211d
Compare
ehsan-2019
reviewed
Aug 1, 2024
lib/process-services-cloud/src/lib/people/components/people-cloud.component.html
Outdated
Show resolved
Hide resolved
ehsan-2019
reviewed
Aug 1, 2024
...es-cloud/src/lib/process/process-filters/components/edit-process-filter-cloud.component.html
Outdated
Show resolved
Hide resolved
ehsan-2019
reviewed
Aug 1, 2024
lib/process-services-cloud/src/lib/people/components/people-cloud.component.ts
Outdated
Show resolved
Hide resolved
ehsan-2019
approved these changes
Aug 1, 2024
wojd0
force-pushed
the
AAE-23830-fix-labels-and-chips-in-workspace-filters
branch
4 times, most recently
from
6ecc228
to
a461934
Compare
ehsan-2019
reviewed
Aug 2, 2024
lib/process-services-cloud/src/lib/people/components/people-cloud.component.ts
Show resolved
Hide resolved
ehsan-2019
requested changes
Aug 2, 2024
|
I'll link this PR to the monorepo side of the fix https://github.com/Alfresco/hxp-frontend-apps/pull/8820 |
ehsan-2019
reviewed
Aug 2, 2024
lib/process-services-cloud/src/lib/people/components/people-cloud.component.html
Outdated
Show resolved
Hide resolved
wojd0
force-pushed
the
AAE-23830-fix-labels-and-chips-in-workspace-filters
branch
from
621414c
to
9476d1e
Compare
ehsan-2019
approved these changes
Aug 5, 2024
wojd0
force-pushed
the
AAE-23830-fix-labels-and-chips-in-workspace-filters
branch
from
9476d1e
to
c8cfe04
Compare
|
ehsan-2019
deleted the
AAE-23830-fix-labels-and-chips-in-workspace-filters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/AAE-23830?focusedCommentId=1317122
What is the new behaviour?
Filter updating logic got more efficient. Due to removal of the intermediate empty state of asynchronously fetched filter properties the form will not pop in-and-out with values on changes.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: