Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dependency.activemq.version from 5.17.4 to 5.18.2 #2037

Closed
wants to merge 1 commit into from
Closed

Bump dependency.activemq.version from 5.17.4 to 5.18.2 #2037

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 3, 2023 •
edited
Loading

Bumps dependency.activemq.version from 5.17.4 to 5.18.2.
Updates activemq-client from 5.17.4 to 5.18.2

Commits
  • 9cbf58d [maven-release-plugin] prepare release activemq-5.18.2
  • cd432f7 [AMQ-9268] Upgrade to maven-source-plugin 3.3.0
  • 88649df [AMQ-9273] Upgrade to maven-shade-plugin 3.4.1
  • 9e21c62 [AMQ-9260] Upgrade to maven-assembly-plugin 3.6.0
  • a782c24 Revert "[AMQ-9260] Upgrade to maven-assembly-plugin 3.6.0"
  • 98c9c1a Revert "[AMQ-9273] Upgrade to maven-shade-plugin 3.4.1"
  • 0225460 On startup inform to inpsect log4j2.properties
  • 076944e [AMQ-9286] Upgrade to Apache POM 30
  • 8981e5f Revert "[AMQ-9268] Upgrade to maven-source-plugin 3.3.0"
  • b290292 Revert "Use jar-no-fork goal for maven-source-plugin to avoid potential dupli...
  • Additional commits viewable in compare view

Updates activemq-pool from 5.17.4 to 5.18.2

Commits
  • 9cbf58d [maven-release-plugin] prepare release activemq-5.18.2
  • cd432f7 [AMQ-9268] Upgrade to maven-source-plugin 3.3.0
  • 88649df [AMQ-9273] Upgrade to maven-shade-plugin 3.4.1
  • 9e21c62 [AMQ-9260] Upgrade to maven-assembly-plugin 3.6.0
  • a782c24 Revert "[AMQ-9260] Upgrade to maven-assembly-plugin 3.6.0"
  • 98c9c1a Revert "[AMQ-9273] Upgrade to maven-shade-plugin 3.4.1"
  • 0225460 On startup inform to inpsect log4j2.properties
  • 076944e [AMQ-9286] Upgrade to Apache POM 30
  • 8981e5f Revert "[AMQ-9268] Upgrade to maven-source-plugin 3.3.0"
  • b290292 Revert "Use jar-no-fork goal for maven-source-plugin to avoid potential dupli...
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jul 3, 2023
@dependabot dependabot bot mentioned this pull request Jul 3, 2023
Closed
@viepovsky
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/dependency.activemq.version-5.18.2 branch from cc28962 to 70eaa98 Compare July 10, 2023 10:51
@viepovsky viepovsky self-requested a review July 10, 2023 11:44
viepovsky
viepovsky reviewed Jul 10, 2023
View reviewed changes
Copy link
Contributor

@viepovsky viepovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 4 connected PRs.
This one changes activemq-client and activemq-pool , 3 others only activemq-client.
The problem is that the updated dependency has more than 350 commits and the oldest one is from February 2022.
The 3 PR which updates only activemq-client pass the tests but this PR does not.
Is it safe to update 3 PR which pass tests or not at all?
1 - Alfresco/gytheio#646
2 - https://github.com/Alfresco/alfresco-transform-service/pull/764
3 - Alfresco/alfresco-transform-core#835

@viepovsky viepovsky requested a review from dsibilio July 10, 2023 11:54
@dsibilio
Copy link
Contributor

There are 4 connected PRs. This one changes activemq-client and activemq-pool , 3 others only activemq-client. The problem is that the updated dependency has more than 350 commits and the oldest one is from February 2022. The 3 PR which updates only activemq-client pass the tests but this PR does not. Is it safe to update 3 PR which pass tests or not at all? 1 - Alfresco/gytheio#646 2 - Alfresco/alfresco-transform-service#764 3 - Alfresco/alfresco-transform-core#835

The activemq-client should be updated at the same time as the ActiveMQ server we use for testing purposes. We can't upgrade the ActiveMQ version at this time, this work is always scheduled as a standalone supported platform upgrade and is not part of the DependaBot cleanup. Please disregard these PRs.

dsibilio
dsibilio requested changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@dsibilio dsibilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge for DependaBot cleanup purposes, only merge as part of a planned supported platform stack upgrade.

@dependabot
Bump dependency.activemq.version from 5.17.4 to 5.18.2
250777a 
Bumps `dependency.activemq.version` from 5.17.4 to 5.18.2.

Updates `activemq-client` from 5.17.4 to 5.18.2
- [Commits](apache/activemq@activemq-5.17.4...activemq-5.18.2)

Updates `activemq-pool` from 5.17.4 to 5.18.2
- [Commits](apache/activemq@activemq-5.17.4...activemq-5.18.2)

---
updated-dependencies:
- dependency-name: org.apache.activemq:activemq-client
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.activemq:activemq-pool
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/maven/dependency.activemq.version-5.18.2 branch from 70eaa98 to 250777a Compare July 25, 2023 12:47
@pzhyland
Copy link
Contributor

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 25, 2023

Looks like these dependencies are no longer a dependency, so this is no longer needed.

@dependabot dependabot bot closed this Aug 25, 2023
@dependabot dependabot bot deleted the dependabot/maven/dependency.activemq.version-5.18.2 branch August 25, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viepovsky viepovsky viepovsky left review comments

@dsibilio dsibilio dsibilio requested changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viepovsky @dsibilio @pzhyland