Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in visualizing tests/yaml/deep_history.yaml #111

Closed
rajivr opened this issue Aug 30, 2021 · 6 comments
Closed

Error in visualizing tests/yaml/deep_history.yaml #111

rajivr opened this issue Aug 30, 2021 · 6 comments

Comments

@rajivr
Copy link

rajivr commented Aug 30, 2021

Firstly, thanks a lot for this tool. I accidentally discovered it, and I am really glad I found it.

I am new to sismic. I was trying to visualize tests/yaml/deep_history.yaml, and it looks likes plantuml is throwing an error.

Sismic version is current master (commit e8b585f90d)

Here are the steps that I followed.

$ sismic-plantuml deep_history.yaml > deep_history.uml

$ plantuml deep_history.uml 
Error line 39 in file: deep_history.uml
Some diagram description contains errors

$ plantuml -version
PlantUML version 1.2021.9 (Sun Jul 25 15:43:56 IST 2021)
(GPL source distribution)
Java Runtime: OpenJDK Runtime Environment
JVM: OpenJDK 64-Bit Server VM
Default Encoding: UTF-8
Language: en
Country: US
 
PLANTUML_LIMIT_SIZE: 4096

Dot version: dot - graphviz version 2.47.3 (0)
Installation seems OK. File generation OK

Here is the image that is generated by plantuml.

deep_history

@AlexandreDecan
Copy link
Owner

Hello,

Thanks for having reported this issue! I'll have a look at it within the next few days. :)

@AlexandreDecan
Copy link
Owner

For what I see, it seems this "issue" is on PlantUML side. The current implementation does not support concurrent state with outgoing transitions. A similar limitation arises when trying to visualize "nested_parallel.yaml", but not "elevator.yaml" for example.

I have no idea what I could do to fix this, unfortunately... :(

Related discussions:

@tommens
Copy link
Contributor

tommens commented Aug 30, 2021

If PlantUML does not respect the UML 2.5 specification w.r.t. what is possible to specify in certain statecharts, then it is indeed difficult to do anything about it from the side of Sismic. PlantUML should try to fix this problem. (I do not know if they will do this anywhere soon, given that some of the issues are "due to the current implementation" of PlantUML.

@AlexandreDecan
Copy link
Owner

The first (above) discussion dates back to 2014. The second one was created this year, in March. I hope it will receive more feedback :)

@rajivr
Copy link
Author

rajivr commented Aug 31, 2021

Thanks @tommens and @AlexandreDecan for the feedback and the pointers.

@AlexandreDecan
Copy link
Owner

Sorry, we made no progress on this issue. Yesterday, we discovered that PlantUML introduced a backward incompatible change in their render pipeline for statecharts. This "bug" was reported to them more than one year ago (by someone else), and they did nothing about it, so I doubt you should expect any fix for the above issue given how reactive they are :-/

I'll have a look "soon" at Mermaid.JS to replace/complement PlantUML in Sismic, but last time I looked at it, it was far from supporting all the features we need.

@AlexandreDecan AlexandreDecan closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants