-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thorium 2024 Discussion Issue #248
Comments
@lawyer88 Already ahead of you. Im working on a hybrid UI. It keeps the tab search button on the right (it already is changed that way now), but also restores the tab height, tab separators, and the square shape of menus. See commit Alex313031/thorium@07bd646 Im calling it "Thorium 2024 UI" or "Th23", to mimick the Cr23 that it aims to fix |
Thank you very much for your answer, but after clicking on the link I didn’t understand anything, unfortunately :) because I don't have any special knowledge in this area. |
@Alex313031 |
Thanks so much for working on this @Alex313031, and for the Thorium fork itself. The atrocious 2023 UI is what brought me to Thorium in the first place, and I must say, it's fantastic work you've done. Glad to know the 'old UI' will be reintegrated as well. I plan to remain on Version 124.0.6367.218 until it's ready (that's how much I despise the 2023 UI!).
Small request - is it possible to retain the yellow bookmark folder icon? I don't know why Chromium (and Firefox) opted to replace it with the colorless 'wireframe' folder icon. It just looks so drab in comparison, like a folder skeleton.. |
Thanks for the advice! I uninstalled the new version and installed the old one) I had no complaints about it)) |
I like the UI design of Fluent Design. Could you incorporate some elements of that design into the interface, even if it's just partial? |
I too migrated to Thorium to avoid the terrible 126 UI but running 124 is simply not an option due to some of the major security holes that were patched after that version. Running 124 to avoid the UI is very risky business since so many sites are now abusing one of the flaws. But at least Thorium plays nicer with the terrible UI than all the other chromium forks I've tried. Thorium is still the best bet though it's a shame all of the chromium browsers are now visually ruined for the time being. |
@SolenoidMan - thanks for heads up on the v124 security issues. Just installed the upgrade. Figured no sense in taking a security risk over minor/temporary UI gripes. |
For me, the #force-enable-tab-outlines came in clutch. Earlier it was useless but after cr23 this is essential for me (I use a dark theme). |
Thankyou very much for this reply, I use black themes and this was a major improvement in visibility. |
Honestly my main issue with the new interface is that hitting the top left corner of the screen no longer opens the first tab due to the padding they added. Kinda messed with years of muscle memory lol. |
@Delphox @Templayer @joshbali @Markosz22 @lawyer88 @tigers-aye @Malus-risus New beta "Th24" release that fixes this and more > https://github.com/Alex313031/thorium/releases/tag/M126.0.6478.246 |
I have to admit, this is kinda awesome. Haven't tested it (I'm tired of everything being unpolished nowadays), but can't wait to get a stable and polished version for this. I always wanted somebody to middle-finger them like this. |
@Alex313031 Do you have this plan? |
It's great, but how can you apply all this to the torium so that everything returns to the old design?) I didn’t see the instructions in the description (or didn’t understand it)... :) Please ask - is it possible to write down detailed instructions for returning the old design? Without special knowledge it is difficult to understand :( |
It is written in the post you have quoted.
So in the URL bar (where you USUALLY enter the URL addresses of websites), enter chrome://flags/#thorium-2024 and enable it. And, of course, you have to download and install (or use the portable) the test Thorium version from the link you have quoted. If you do not know how to install a browser, then use www.google.com |
I tested it on a live Linux environment and like it visually! It did seem to create an invisible border at the top when not using the system titlebar which would make switching tabs very annoying (as well as not fixing the corner click issue I mentioned earlier), but I'd assume this is part of the bugs you mentioned earlier and will be addressed. VirtualBoxVM_2024-08-23_12-27-20.mp4Here's a quick recording of what I mentioned (first is 124 with the ideal behavior, then 126 with the top click working but not the corner click, and then enabling the flag where neither works). |
Thank you very much! |
Yup, I'm waiting for a polished and spotless version myself. :P |
I'm glad you're working on it! I want to clarify some problems with the menus. Sure, the corners and whitespace make it take up way too much room. But it seems the biggest culprit of needing to scroll the menu is that the menu always spawns at the around the same horizontal coordinate of the mouse cursor. And it always cuts off way too early, well before it reaches the task bar. This is not how standard menus work. When you right click, the menu will appear at the same Y-coordinate if all the items will fit. It will keep expanding until the bottom right coordinate reaches the task bar But if the items don't fit, the top left coordinate moves up. Only once the top coordinate reaches up to the top of the screen (and the bottom coordinate is just above the taskbar) will the menu start to scroll. Microsoft Edge implements the overly large curved menus. However, it does at least handle the menu behavior correctly. Note, if the menu is small enough, it may spawn the bottom left coordinate at the mouse cursor instead of the top right. This is desirable behavior, but irrelevant to the scrolling issue. |
Any chance you can release a Windows build for testing as well? I ask because I noticed a different behavior in Linux, even before enabling your flag. When I clicked the three dot menu, the menu moved up like I want. It would be good to confirm things work on Windows as well before the next full release. Plus you'd get a lot more testers--I'm lucky I had a Linux VM from long ago. |
@Alex313031 |
@Delphox The tab selection issue is addressed in the new Beta 2 release > https://github.com/Alex313031/thorium/releases/tag/M126.0.6478.251 @joshbali I will add that to my todo, to restore the old icons when Th24 is enabled. NOTE: Merging issue Alex313031/thorium#769 into this one. |
Thank you for your work, I tried the second beta on Windows and the theme is already very nice. Can't wait for the more stable version on M127! |
Any chance this can be a tweakable setting? I don't think I've ever intentionally middle-clicked on a bookmark folder. I like that it warns me when I do that. |
@Alex313031 |
@firegold763 How did you test the second beta on Windows? I can't find a built yet. Did you build it yourself, or is it available elsewhere? |
Thanks! I can confirm it's fixed and its looking very good. If possible I'd like you to look into making the first tab clickable when clicking on the top-left corner/side as it was in v124, but if you don't wanna remove that padding for aesthetic reasons I understand, this is still a lot better. |
@Delphox This isn't really feasible without a bunch more redesigning of the tab strip. Probably wont be adding that, sorry. However, I might make tabs closer to the left to make the first one easier to click. |
It may be apt to give us an option to disable/enable that. :p |
@trlkly @Templayer @Delphox @firegold763 New Windows Beta 2 just released, that has these fixes and more, as well as a new flag to set a custom tab width. |
@Alex313031 |
@joshbali OK, I will add 180px, and bookmarks icon is in the works. Will probably stop there, and finalize it for the stable M128 release. I might add even more widths (I just don't want to add a textbox, if you read the release notes, and I also don't want the dropdown menu for the sizes to get to long) Future work on Th24 will not be done after the above until the next release after M128. |
Sounds like a plan. This way, even people like me who require stable releases can enjoy it. :) |
I updated the browser to the latest version and found that the interface was disfigured by the latest one in Chrome...
For me personally, when switching to Torium, the main advantage was the ability to use a minimalistic interface... How can I get it back? Bleeding from the eyes from the “New Design”... I wouldn’t want to look for a new suitable browser again
The text was updated successfully, but these errors were encountered: