-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: test targets #3378
base: mainnet-staging
Are you sure you want to change the base?
feat: test targets #3378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if you update the Cargo.toml to the rev of AleoNet/snarkVM#2529 (which is just for illustrative purposes, as the maintainer will have to update it anyway)
a7faa94
to
05d142d
Compare
Does this apply to compiled |
@raychu86 I've updated the description. Let me know if still not clear. |
So if We need some sort of enforcement that the |
05d142d
to
ca04d15
Compare
ca04d15
to
25631ef
Compare
Motivation
Add feature flag to be able to lower coinbase and proof targets for testing purposes. This feature flag will lower the proof and coinbase targets to 8 and 32 respectively.
The feature flag needed to be cascaded to all dependencies of snarkVM to be sure everything uses same constants.
To use, compile with
--features test_targets
e.g.
Test Plan
tested by using tx-cannon and adding println to verify correct targets.
CI link
Related PRs
Must first merge AleoNet/snarkVM#2529 and the snarkVM revision must be updated in snarkOS in 2 places before merging this.