[Fix] Cache block requests on the gateway #3369
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklaslong
changed the title
niklaslong
changed the title
niklaslong
force-pushed
the
fix/3324-block-request-cache
branch
from
b320493
to
406e323
Compare
niklaslong
changed the title
niklaslong
force-pushed
the
fix/3324-block-request-cache
branch
4 times, most recently
from
360d462
to
6576f25
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements caching for block requests so they can be rate limited and matched to inbound block responses. I have also refactored some verbose branching logic to use
matchstatements in the second commit. It can be dropped, if a smaller diff is preferred.I've opted to clear the outbound block request cache in the same way as the validator requests (#3254). Time-based expiry isn't necessary as the committee is bounded and the collection is cleared on peer disconnect. Inbound requests use a time-based expiry.
Fixes #3324.