[Fix] Clear seen_outbound_block_requests on peer disconnect #3330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ljedrz <[email protected]>
niklaslong
approved these changes
Jun 25, 2024
joske
approved these changes
Jun 25, 2024
raychu86
approved these changes
Jul 3, 2024
|
@ljedrz @niklaslong Can you run CI on this? |
raychu86
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clears a peer's
seen_outbound_block_requestswhen it gets disconnected.There may be other cache collections (in
Router) that require this sort of adjustment, and this depends on whether they too need to be invalidated once the peer is disconnected. Once this PR is merged, this will only require additional lines to be added toCache::clear_peer_entries.Fixes #3326.