You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The metrics feature is enabled by default, so the fact that there exists a metrics feature is confusing. diff.txt.
Additionally, even if the metrics are disabled (see appended diff), the metrics endpoint is still accessible.
This cleanup is not high priority by itself, but it is key that features are handled uniformly so that we don't mess up implementing consensus-critical features like test_targets
Expected Behavior
Ideally:
The top-level Cargo.toml has metrics in its default feature list, which can be used to enable or disable all metrics functionality
The metrics endpoint is not available if the metrics feature is not enabled.
The text was updated successfully, but these errors were encountered:
🐛 Bug Report
The metrics feature is enabled by default, so the fact that there exists a
metrics
feature is confusing.diff.txt.
Additionally, even if the metrics are disabled (see appended diff), the metrics endpoint is still accessible.
This cleanup is not high priority by itself, but it is key that features are handled uniformly so that we don't mess up implementing consensus-critical features like test_targets
Expected Behavior
Ideally:
Cargo.toml
has metrics in itsdefault
feature list, which can be used to enable or disable all metrics functionalitymetrics
feature is not enabled.The text was updated successfully, but these errors were encountered: