Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Clean up metrics feature flag #3379

Open
vicsn opened this issue Aug 13, 2024 · 0 comments
Open

[Bug] Clean up metrics feature flag #3379

vicsn opened this issue Aug 13, 2024 · 0 comments
Labels
bug Incorrect or unexpected behavior

Comments

@vicsn
Copy link
Contributor

vicsn commented Aug 13, 2024

🐛 Bug Report

The metrics feature is enabled by default, so the fact that there exists a metrics feature is confusing.
diff.txt.

Additionally, even if the metrics are disabled (see appended diff), the metrics endpoint is still accessible.

This cleanup is not high priority by itself, but it is key that features are handled uniformly so that we don't mess up implementing consensus-critical features like test_targets

Expected Behavior

Ideally:

  1. The top-level Cargo.toml has metrics in its default feature list, which can be used to enable or disable all metrics functionality
  2. The metrics endpoint is not available if the metrics feature is not enabled.
@vicsn vicsn added the bug Incorrect or unexpected behavior label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect or unexpected behavior
Projects
None yet
Development

No branches or pull requests

1 participant