Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cropperjs instead of Jcrop #3047

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Use cropperjs instead of Jcrop #3047

merged 1 commit into from
Sep 20, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Sep 20, 2024

What is this pull request for?

JCrop is not maintained anymore and uses jQuery.
Cropperjs is a maintained jQuery-less alternative.

Checklist

@tvdeyen tvdeyen requested a review from a team as a code owner September 20, 2024 09:58
@tvdeyen tvdeyen added this to the 8.0 milestone Sep 20, 2024
JCrop is not maintained anymore and uses jQuery.
Cropperjs is a maintained jQuery-less alternative.
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (8c835bf) to head (7233e12).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3047   +/-   ##
=======================================
  Coverage   96.63%   96.63%           
=======================================
  Files         236      236           
  Lines        6332     6332           
=======================================
  Hits         6119     6119           
  Misses        213      213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit 8225f88 into AlchemyCMS:main Sep 20, 2024
39 checks passed
@tvdeyen tvdeyen deleted the cropperjs branch September 20, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants