Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ingredient output as html_safe #2779

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Mark ingredient output as html_safe #2779

merged 1 commit into from
Mar 8, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Mar 8, 2024

What is this pull request for?

All our ingredient view components values are html_safe.

Closes #2737

Checklist

@tvdeyen tvdeyen requested a review from a team as a code owner March 8, 2024 11:54
@tvdeyen tvdeyen added backport-to-7.0-stable Needs to be backported to 7.0-stable backport-to-7.1-stable Needs to be backported to 7.1-stable labels Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.80%. Comparing base (a95c95d) to head (d091160).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2779   +/-   ##
=======================================
  Coverage   95.80%   95.80%           
=======================================
  Files         221      221           
  Lines        6073     6078    +5     
=======================================
+ Hits         5818     5823    +5     
  Misses        255      255           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

All our ingredient view components values are html_safe.
@tvdeyen tvdeyen merged commit c5172b4 into main Mar 8, 2024
35 checks passed
@tvdeyen tvdeyen deleted the component-safe-output branch March 8, 2024 16:19
@alchemycms-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
7.0-stable
7.1-stable

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-7.0-stable Needs to be backported to 7.0-stable backport-to-7.1-stable Needs to be backported to 7.1-stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ViewComponent HTML safety warnings
3 participants