Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include timezone in datepickers only displaying date #2767

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Mar 4, 2024

What is this pull request for?

We must not include timezone information when storing date columns. It would lead to wrongly stored dates otherwise.

Follow up to #2462

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen added bug backport-to-7.0-stable Needs to be backported to 7.0-stable backport-to-7.1-stable Needs to be backported to 7.1-stable labels Mar 4, 2024
@tvdeyen tvdeyen requested a review from a team March 4, 2024 20:24
We must not include timezone information when storing date
columns. It would lead to wrongly stored dates otherwise.
@tvdeyen tvdeyen merged commit 871842d into main Mar 5, 2024
34 checks passed
@tvdeyen tvdeyen deleted the fix-datepicker-date-input branch March 5, 2024 07:34
@alchemycms-bot
Copy link
Collaborator

💔 Some backports could not be created

Status Branch Result
7.0-stable Backport failed because of merge conflicts

You might need to backport the following PRs to 7.0-stable:
- Merge pull request #2761 from tvdeyen/fix-taggable-uniq
- Merge pull request #2735 from tvdeyen/fix-tags
7.1-stable

Manual backport

To create the backport manually run:

backport --pr 2767

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-7.0-stable Needs to be backported to 7.0-stable backport-to-7.1-stable Needs to be backported to 7.1-stable bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants