Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified layout changes - scott #34

Closed
wants to merge 2 commits into from
Closed

Conversation

JonathonDunford
Copy link
Member

@JonathonDunford JonathonDunford commented Apr 18, 2018

Closes #16

This gets rid of a lot of the specific height settings that made the layout difficult to work with. Benefits are:

  • More robust layout in general with less jumping around and odd behavior on specific browsers (like the intermittent #102)
  • Responsive layout on narrow/mobile devices (now it renders each widget box on a screen at a time even on very small devices)
  • Divides the rows of widgets into equal parts to reduce jagged "lines" in the layout

Todo

  • Testing & Approving Review

@JonathonDunford JonathonDunford changed the title @activescott 's changes moved into a PR here. Unified layout changes - scott Apr 18, 2018
@JonathonDunford
Copy link
Member Author

Overall, it definitely looks better, but there are a few things to fix:

Issue 1:

Check out this screenshot.
I am on a 1920x1080 monitor.
The table for balances/deposits/etc. need to be full width.

https://imgur.com/a/JDKWi

Issue 2:

Some of the scroll bars aren't styled. Check in Chrome.

Check this screenshot: https://imgur.com/a/ej6fV

Issue 3:

On Mobile, the same problem as Issue 1 happens.

ALSO, the bottom of the "Make sure XXX" text gets cut off and the whole block becomes scrollable. Can we make it all in view without having to scroll the separate section?

Issue 4:

The order section cuts off for me on mobile as well.

I fixed these issues on our live CSS by setting minimum widths on mobile.

Issue 5:

I would change "Updates" to "News"

@JonathonDunford
Copy link
Member Author

Issue 1 -> 5 should be fixed with the last commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

working on a new layout
2 participants