Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Token Logos #14

Open
JonathonDunford opened this issue Mar 27, 2018 · 5 comments
Open

Adding Token Logos #14

JonathonDunford opened this issue Mar 27, 2018 · 5 comments

Comments

@JonathonDunford
Copy link
Member

Issue by ivoilic
Thursday Feb 22, 2018 at 01:06 GMT
Originally opened as https://github.com/forkdelta/forkdelta.github.io/issues/81


I'd highly recommend adding token logos next to their symbols.
It could easily be added as part of the application process for new tokens.
Having a visual cue other than just the symbol would make it easier to trade and use the site.

@JonathonDunford
Copy link
Member Author

Comment by freeatnet
Thursday Feb 22, 2018 at 07:42 GMT


I like this idea. Unfortunately, it's somewhat hard to collect token logos. Do you know any sources for that?

@JonathonDunford
Copy link
Member Author

Comment by ivoilic
Thursday Feb 22, 2018 at 08:26 GMT


If you can give me a list of token names in a plaintext format I can write a super quick scraper and grab the images from a reliable website. In the future new tokens should probably be required to submit a link to a logo in order to get listed.

@JonathonDunford
Copy link
Member Author

Comment by freeatnet
Thursday Feb 22, 2018 at 08:43 GMT


Take a look at https://github.com/forkdelta/tokenbase :)

https://github.com/forkdelta/tokenbase/tree/master/tokens has all the listed tokens
and https://github.com/forkdelta/tokenbase/tree/master/scripts/ has some internal scripts we use to generate token description files (including token_info.py, a scraper)

@JonathonDunford
Copy link
Member Author

Comment by mrmm
Thursday Feb 22, 2018 at 17:01 GMT


Hey @freeatnet @ivoilic I have been working on a script to scrape icons form the website of there tokens.
I will make a pull request tomorrow.

@JonathonDunford
Copy link
Member Author

Comment by mishfit
Wednesday Feb 28, 2018 at 03:01 GMT


Just a thought, pull from etherscan or have each token author make a PR into tokenbase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant