Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For CFNMain, the update command exits with 0 even if the update fails #155

Open
adanaja opened this issue Dec 6, 2022 · 0 comments
Open

Comments

@adanaja
Copy link
Contributor

adanaja commented Dec 6, 2022

In execute_for_stack we do the following to update an existing stack:

if self.args.apply_changeset:
    ask = input("Apply change (y/N): ")
    if ask[0] in "Yy":
        stack.execute_change_set(
            changeset_name=changeset_name,
            wait=self.args.wait_stack_creation,
        )
return 0

execute_change_set is a function that logs the new stack status logging.info(f"Done (status: {self.wait()})") but doesn't indicate a failure, so the update command exits with 0 even if the stack has not been updated because of errors.

The update command should exit with an error code if the stack could not be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant