Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we use logger insted of io:format? #17

Open
elbrujohalcon opened this issue Jan 25, 2022 · 0 comments
Open

Can we use logger insted of io:format? #17

elbrujohalcon opened this issue Jan 25, 2022 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@elbrujohalcon
Copy link
Collaborator

elbrujohalcon commented Jan 25, 2022

rebar3_typer version

0.0.1

Description

  • Motivation
    Even when after Send output through rebar3 #11, we'll use the rebar_api loggers for the plugin, the default code in rebar3_mini_typer still uses io:format (with the idea that it should not be tied to rebar - like we stated in Verify if we can contribute back to OTP #15). It's not terrible, but maybe we can take advantage of the new logger system.

  • Proposal
    Use logger as the default io() for rebar3_mini_typer.

Current behavior

io:format is the default io().

Expected behavior

logger:_something_ being the default io().

@elbrujohalcon elbrujohalcon added the enhancement New feature or request label Jan 25, 2022
@elbrujohalcon elbrujohalcon added this to the 1.0.0 milestone Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant