Added installable githook for creating a platform commit with the buildscript changes. #3529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ldscript changes. The hook also auto-updates the buildscript with any resulting changes prior to commit.
Naatan
requested changes
Oct 7, 2024
|
It may look like it, but it wasn't enabled as our pre-commit hook. I agree that we don't want that. If it was in a .githooks directory (with the dot), then it would be. Regardless, I have applied your suggested name change and added some usage information to compensate. |
Naatan
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hook also auto-updates the buildscript with any resulting changes prior to commit.
The end result is that the committed buildscript will be the latest one, but it may NOT be what the user intended to commit. For example, if the ordering of requirements in the platform commit's buildscript is different, the buildscript committed locally will have the new order, not the order the user originally intended to commit.