Add config list #3528
Merged
Add config list #3528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MDrakos
commented
Oct 3, 2024
•
MDrakos
commented
 DX-3055 Users can list available and configured config keys/values with `state config`
|
Naatan
requested changes
Oct 9, 2024
| @@ -10,13 +10,13 @@ import ( | |||
| func newConfigCommand(prime *primer.Values) *captain.Command { | |||
There was a problem hiding this comment.
We should mark it unstable, since technically this is a new command.
That means we're marking a command that used to be "stable" as "unstable", but given the original command was just printing help output I don't see a problem with that.
I'm pretty sure unstable doesn't propagate to child commands (ie. config set), but please make sure.
There was a problem hiding this comment.
It appears that we do set the child commands to unstable as well. https://github.com/ActiveState/cli/blob/master/internal/captain/command.go#L410
Do we want to find a way to work around this?
Naatan
requested changes
Oct 10, 2024
Naatan
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.