Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Delivery reports for outbound SMS/MMS messages #1

Open
thefinn93 opened this issue Jul 5, 2023 · 6 comments
Open

[FEATURE] Delivery reports for outbound SMS/MMS messages #1

thefinn93 opened this issue Jul 5, 2023 · 6 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@thefinn93
Copy link
Contributor

mod_sms seems to have a concept of delivery reports (via SMS::DELIVERY_REPORT events). We should send them after attempting to send a message, and add receiving handlers on the client side.

@danry25
Copy link
Contributor

danry25 commented Jul 5, 2023

Note that these are supposed to tie into the dlrid that sms.callpipe.com gets back from FirstPoint for outgoing SMS and MMSes and these provide a notification of whether the message was delivered to the network, or delivered to the handset itself (yet). On incoming SMS/MMS I am unclear if we should be providing a DLR response.

Digging now for further information on this, will update once found.

@uncheckederror Any input/info on passing the dlrid and other DLR data through to the client?

@thefinn93
Copy link
Contributor Author

this was just intended to cover cases where we POST to sms.callpipe.com and it doesnt give us 200 back. Delivery reports from higher up would also be nice to have.

@uncheckederror
Copy link
Contributor

uncheckederror commented Sep 4, 2024

@dunkeltron what happens when a message from WebTexting is forwarded to sms.callpipe.com, but the API responds with an HTTP 50x or 40x? How does WebTexting handle non-200 responses for outbound messages?

@uncheckederror uncheckederror added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 4, 2024
@dunkeltron
Copy link
Contributor

dunkeltron commented Sep 4, 2024

it looks like on line 76 of accelerate-networks.php we log any non 200 responses without returning the code to the vue app

@uncheckederror uncheckederror changed the title delivery reports [FEATURE] Delivery reports for outbound SMS/MMS messages Sep 4, 2024
@dunkeltron
Copy link
Contributor

dunkeltron commented Sep 4, 2024

  • it looks like we'd have to add return values to the functions that eventually call accelerate-networks.php _send()

  • as well as add handling to the vue app for getting a non 200 response code (like an alert() that doesn't look bad)

it looks like on line 76 of accelerate-networks.php we log any non 200 responses without returning the code to the vue app

@uncheckederror
Copy link
Contributor

The goal here is to inform the WebTexting user that their outbound message failed to send.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants