Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable undefined behavior checks in transformValues() #1954

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Disable undefined behavior checks in transformValues() #1954

merged 2 commits into from
Oct 29, 2024

Conversation

danrbailey
Copy link
Contributor

This is failing the ubsan checks in Clang 17.

Idclip
Idclip approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@Idclip Idclip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the macro in Platform.h to solve the windows issues, lgtm

@danrbailey
Copy link
Contributor Author

Use the macro in Platform.h to solve the windows issues, lgtm

Thanks, that fixed it!

@danrbailey danrbailey merged commit ff9463c into master Oct 29, 2024
97 of 99 checks passed
@danrbailey danrbailey deleted the feature/ubsan_fix branch October 29, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Idclip Idclip Idclip approved these changes

@kmuseth kmuseth Awaiting requested review from kmuseth kmuseth is a code owner

Assignees
No one assigned
Labels
vdb12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danrbailey @Idclip