Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testminimal and a new testsuite case. #1832

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

johnfea
Copy link
Contributor

@johnfea johnfea commented Jun 21, 2024

Description

This PR adds a new testsuite case that seemed more convenient to add with a new test program instead of modifying testshade. However, if testshade can be easily modified to add this testsuite case then this PR might not be needed, however as is testshade doesn't even call "closure->as_comp()". Also, testrender doesn't support batched mode so that one can't be used for this testsuite case either without major modifications.

Additionally, OSL has no minimal sample and this PR adds one. I needed a minimal sample when I started using OSL.

Also, #1800 and #1801 need new testsuite cases that would be easy to add with testminimal but not necessarily so with testshade.

Tests

I added a new testsuite case "closure-string" that fails in AVX2 batched mode and also with non-batched icc/icx.

#1831 should fix the failed test cases so this would need to be accepted after that one.

Checklist:

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have ensured that the change is tested somewhere in the testsuite (adding new test cases if necessary).
  • My code follows the prevailing code style of this project. If I haven't
    already run clang-format v17 before submitting, I definitely will look at
    the CI test that runs clang-format and fix anything that it highlights as
    being nonconforming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant