Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openexr): modernize dwa compression level setting #4434

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix(openexr): modernize dwa compression level setting #4434

merged 1 commit into from
Oct 3, 2024

Commits on Oct 2, 2024

  1. fix(openexr): modernize dwa compression level setting 

    Starting with OpenEXR 3.1.3, the preferred API call for setting
DWAA/DWAB compression level has changed. We never changed the OIIO
side. Luckily, OpenEXR seems to have kept respecting the old API calls
we were making (passing as an attribute). But this modernizes the
approach, now that we don't have OpenEXR 2.x suppor to maintain.

But in the process, we also fixed a bug! Turns out we weren't
propagating the compression properly -- if the compression name
was plain "dwaa", we ignored any "openexr:dwaCompressionLevel"
attribute, effectively.

Signed-off-by: Larry Gritz <[email protected]>
    @lgritz
    lgritz committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    ecdfe06 View commit details
    Browse the repository at this point in the history