deps: Add build recipe for ZLIB #4420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachlewis
force-pushed
the
build_zlib
branch
from
d8a78fd
to
6c09129
Compare
|
I looked at the "all local builds" CI test, and it's still using the system zlib, not exercising this new builder script. I think it's because you named this file build_zlib.cmake, but that doesn't match the I think maybe if it was working for you, it was only because you were using a case-insensitive file system? |
I'm dumb. I had this set up properly in one branch, and copy-pasted the contents to a file in another branch without checking the filename. Good catch...! |
Required for building redistributable python wheels on Windows Wheels runners. Signed-off-by: Zach Lewis <[email protected]>
zachlewis
force-pushed
the
build_zlib
branch
from
6c09129
to
0d33c4c
Compare
lgritz
merged commit c658c8f
into
AcademySoftwareFoundation:master
25 of 27 checks passed
zachlewis
added a commit
to zachlewis/OpenImageIO
that referenced
this pull request
Sep 17, 2024
Required for building redistributable python wheels on Windows Wheels runners. Signed-off-by: Zach Lewis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for building redistributable python wheels on Windows Wheels runners.