fix: normalize cleanup #3963
Merged
fix: normalize cleanup #3963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add documentation for oiiotool --normalize * Add tests for oiiotool --normalize * Revamp existing normalize tests in testsuite/python-imagebofalgo: Get rid of old test images and refs, because their values were already normalized, so was probably not testing the math. Make new tests that are much smaller, 3x3 images that contain specific (non-normalized) values to verify they all get normalized corectly. They'll run a lot faster, too. Signed-off-by: Larry Gritz <[email protected]>
|
@ssh4net How does this look to you? |
ssh4net
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation for oiiotool --normalize
Add tests for oiiotool --normalize
Revamp existing normalize tests in testsuite/python-imagebofalgo: Get rid of old test images and refs, because their values were already normalized, so was probably not testing the math. Make new tests that are much smaller, 3x3 images that contain specific (non-normalized) values to verify they all get normalized corectly. They'll run a lot faster, too.