Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Convert iconvert.cpp stream io and sprintf to modern #3925

Merged
merged 2 commits into from
Jul 25, 2023
Merged

refactor: Convert iconvert.cpp stream io and sprintf to modern #3925

merged 2 commits into from
Jul 25, 2023

Conversation

lgritz
Copy link
Collaborator

@lgritz lgritz commented Jul 24, 2023

Also fix a typo

jessey-git
jessey-git reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@jessey-git jessey-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment

src/iconvert/iconvert.cpp Show resolved Hide resolved
@lgritz
Adjust includes
79b6071 
Signed-off-by: Larry Gritz <[email protected]>
jessey-git
jessey-git approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@jessey-git jessey-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgritz lgritz merged commit b205899 into AcademySoftwareFoundation:master Jul 25, 2023
22 of 23 checks passed
@lgritz lgritz deleted the lg-iconvert branch July 25, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessey-git jessey-git jessey-git approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgritz @jessey-git