Fix graph editor defect for name setting #1431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for this great proposal, @ZelboK, and I've written up a couple of suggestions for changes below.
…#1422) As discussed on Slack, add a line clarifying that an image node will output the first N channels from the image file if the image file has more channels than the image node. Also updated the link target for the surface_unlit node to conform to naming conventions used in other nodes with underscores in their name.
ZelboK
force-pushed
the
fix/set-name-graph-editor
branch
from
22a9284
to
e3c7e32
Compare
|
I wanted to follow up on this proposal, @ZelboK, to see if you have the bandwidth to bring it over the finish line. If so, then there's some discussion above on how to move forward with a broader solution that we can merge. Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The graph editor has a problem where if you highlight the name in the imgui textbox and press the delete key, it will cause a cycle exception. This isn't caught anywhere, thus leading to crashes.
As such, just a simple method that checks if the name is empty(and if it is, fixes it) is enough to avoid this issue.