Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MaterialX Python to PyPi #570

Closed
jstone-lucasfilm opened this issue Jan 25, 2021 · 9 comments · Fixed by #1317
Closed

Add MaterialX Python to PyPi #570

jstone-lucasfilm opened this issue Jan 25, 2021 · 9 comments · Fixed by #1317
Assignees

Comments

@jstone-lucasfilm
Copy link
Member

Add the MaterialX Python library to the PyPi registry, making it available from the command line via "pip install" on Windows, Linux, and MacOS. Some starting references may be found below:

https://pypi.org/
https://github.com/pybind/python_example

@meshula
Copy link

meshula commented Jan 25, 2021

And Conda, while you're at it :)

@jstone-lucasfilm jstone-lucasfilm changed the title [Lucasfilm] Add MaterialX Python to PyPi Add MaterialX Python to PyPi Jul 20, 2022
@JeanChristopheMorinPerso
Copy link
Member

Here is a small list of ASWF examples:

The general idea is to run the build from the setup.py. I'll be more than happy to help if needed.

@TRohit20
Copy link

TRohit20 commented Mar 1, 2023

Hey everyone, Can the project maintainers assign this issue to me so I can get the task done and open a PR resolving the same. Thank you.

@jstone-lucasfilm
Copy link
Member Author

That would be much appreciated, @TRohit20! Let's check with @kwokcb and @JeanChristopheMorinPerso before proceeding, since they have expressed interest in this feature as well, but otherwise I would have no reservations about assigning the issue to you.

@TRohit20
Copy link

TRohit20 commented Mar 2, 2023

Awesome, Looking forward to work on it if it gets assigned

@jstone-lucasfilm
Copy link
Member Author

Thanks for offering to take this on, @TRohit20, and feel free to reach out to @JeanChristopheMorinPerso, @kwokcb, or me if you have questions!

@TRohit20
Copy link

TRohit20 commented Mar 3, 2023

Sure thing, I will get started from tomorrow!

@jstone-lucasfilm
Copy link
Member Author

@TRohit20 Just checking in on this GitHub Issue, to see if you've had a chance to take an initial look. We've incorporated a couple of improvements to our Python package in preparation for MaterialX 1.38.7, and these could end up being helpful in integrating MaterialX with PyPi as well:

#1237
#1313

@JeanChristopheMorinPerso
Copy link
Member

I created a PR: #1317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants