Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx Python Documentation #342

Open
jstone-lucasfilm opened this issue Jan 15, 2020 · 2 comments
Open

Sphinx Python Documentation #342

jstone-lucasfilm opened this issue Jan 15, 2020 · 2 comments
Assignees

Comments

@jstone-lucasfilm
Copy link
Member

Add support for the generation of Sphinx documentation for MaterialX Python, using the approach described here:

https://pybind11.readthedocs.io/en/stable/advanced/misc.html#generating-documentation-using-sphinx

lvxejay pushed a commit to ForgeXYZ/MaterialX that referenced this issue Jul 9, 2020
…AcademySoftwareFoundation#342)

* Build fixes
- Make Viewer conditionally require render builds
- Remove duplicate installs of resources and libraries by fixing up search path logic to allow for current path as well as parent path.
Current install puts the resources/ and libraries/ under the same directory as bin/.
- Add in pop() method on FilePath to allow to get parent.

* Create Util file and pull out some Material class logic into it.

* Movement of UI / introspection utilities the render utils.

* - Fix up extension storage and usage for image file dialog so it's not fixed.
- Fix so that we use v-flip for textures so texture are not flipped.

* Review fixes. Add in VariantBlock search function based on generic predicate function.

* Review fixes.
@jstone-lucasfilm jstone-lucasfilm changed the title [Lucasfilm] Sphinx Python Documentation Sphinx Python Documentation Jul 20, 2022
@StefanHabel
Copy link
Contributor

I'd like to take a stab at this for the ASWF Dev Days 2023.

If I’m understanding this right, the work here roughly consists of two parts:

  1. Integrating a Sphinx build of the MaterialX Python API documentation into the MaterialX CMake build
  2. Adding/extending docstrings for MaterialX Python bindings using pybind11

While it may not be possible/feasible to add/curate docstrings for all MaterialX Python bindings during Dev Days, it should be possible to lay the foundation for building API documentation using Sphinx on the day.

Proposed approach/outcome:

  • An optional extra build target similar to the existing cmake --build . --target MaterialXDocs (which uses doxygen to generate C++ API documentation), possibly named MaterialXDocsPython.
  • Documentation in HTML format that is generated in a sibling folder next to the existing C++ API documentation (as opposed to living in the same html folder).

Proposed artifacts:

  1. A new CMake module at cmake/modules/FindSphinx.cmake to be able to find the sphinx-build executable (Windows: sphinx-build.exe) from documents/CMakeLists.txt using find_package(Sphinx).
  2. Modifications to documents/CMakeLists.txt to create a new build target named MaterialXDocsPython, which would run sphinx-build to generate Python API developer documentation, in a directory that is separate to the existing doxygen-generated html documentation, e.g. named html-sphinx.
  3. A Sphinx configuration template file (e.g. documents/sphinx-conf.py.in) that would be filled with values of configuration variables like MATERIALX_LIBRARY_VERSION as part of the build, in order to generate the conf.py file that sphinx-build uses.
  4. Integration of existing developer guide contents in Markdown format from documents/DeveloperGuide/ into the Sphinx-generated Python API documentation, e.g. using the myst_parser extension:
  5. A new paragraph in the Building API Documentation section in documents/DeveloperGuide/MainPage.md to describe how to build the Python API documentation using Sphinx.
  6. Integration of docstrings from MaterialX Python bindings that are defined in source/PyMaterialX/ from compiled Python C extensions, e.g. from lib/PyMaterialXCore.cpython-312-darwin.so etc.

StefanHabel added a commit to StefanHabel/MaterialX that referenced this issue Oct 13, 2023
Work in progress.

This PR adds a new build target named `MaterialXDocsPython`,
which generates Python API documentation using Sphinx.

The existing developer guide contents are incorporated into
the new HTML documentation, which lives side-by-side to the
existing Doxygen-generated C++ API documentation.

The docstrings of the Python modules were tweaked to describe
what the individual modules are responsible for.

Signed-off-by: Stefan Habel <[email protected]>
StefanHabel added a commit to StefanHabel/MaterialX that referenced this issue Oct 16, 2023
Work in progress.

This PR adds a new build target named `MaterialXDocsPython`,
which generates Python API documentation using Sphinx.

The existing developer guide contents are incorporated into
the new HTML documentation, which lives side-by-side to the
existing Doxygen-generated C++ API documentation.

The docstrings of the Python modules were tweaked to describe
what the individual modules are responsible for.

Signed-off-by: Stefan Habel <[email protected]>
StefanHabel added a commit to StefanHabel/MaterialX that referenced this issue Oct 18, 2023
Work in progress.

This PR adds a new build target named `MaterialXDocsPython`,
which generates Python API documentation using Sphinx.

The existing developer guide contents are incorporated into
the new HTML documentation, which lives side-by-side to the
existing Doxygen-generated C++ API documentation.

The docstrings of the Python modules were tweaked to describe
what the individual modules are responsible for.

Signed-off-by: Stefan Habel <[email protected]>
jstone-lucasfilm added a commit to StefanHabel/MaterialX that referenced this issue Oct 25, 2023
jstone-lucasfilm added a commit to StefanHabel/MaterialX that referenced this issue Nov 27, 2023
@StefanHabel
Copy link
Contributor

I'd like to continue our work on this from last year’s ASWF Dev Days next week:
#1567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants