Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One node output driving multiple inputs updates only one #1415

Open
zicher3d opened this issue Jul 17, 2023 · 3 comments
Open

One node output driving multiple inputs updates only one #1415

zicher3d opened this issue Jul 17, 2023 · 3 comments

Comments

@zicher3d
Copy link

See video below, using LookdevX (old version), MaterialX Viewer and Graph Editor, all loading the same attached MtlX file.

The Radius1 node drives the thickness of a few Lines. In LookdevX all works as expected.
In Viewer and Graph Editor only one line updates when changing the Radius1 value.
At load times and when a shader compilation is triggered all nodes are updated correctly. Something that can be done in the Editor but not the Viewer.

one_line_only_update.mp4

Note that this file requires PR1411
When you open the file in Graph Editor the graph is in the upper-right corner, and you need to Zoom in. There are some disconnected nodes that are far away (other bug reported for that issue)
[pat_herringbone2x6_test_GE01.zip]
(https://github.com/AcademySoftwareFoundation/MaterialX/files/12074256/pat_herringbone2x6_test_GE01.zip)

@zicher3d
Copy link
Author

zicher3d commented Sep 12, 2023

Adding another test case for MaterialX 1.38.8
Not sure I am super-clear in the video. But basically this is what happens.

  • I want a float slider input to drive the selection of 10 colors
  • Since Switch only has 5 inputs, I use 2 of them with a 5.0 modulo_float
  • Another node divides the same input by 5.0 and is used in a 3rd switch that selects the output of switch 1 or 2
    In the video you see that if I use 2 separate float inputs everything works, but when I use the same input (as it's supposed to be) then the switch selection does not work. One of the nodes (the divide_float) does not update and the colors are selected from only one of switch 1 or 2.
MaterialXGraphEditor.mp4

The graph
GE_debug_switch.zip

@zicher3d
Copy link
Author

The issue is not Graph Editor specific. The same happens in MaterialX Viewer.

MaterialXView.mp4

@zicher3d
Copy link
Author

I found another issue that is an older version of this one I believe
#779

Some interesting explanation in there and seems that if the graph is then converted to a functional graph (nodedef) it will work. It kind of confirm my suspicion that I have seen my stuff working at times, and that was probably when I was testing the nodedef version of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant