Skip to content
This repository has been archived by the owner on Nov 26, 2021. It is now read-only.

trappy should be able to narrow the trace to the actual run if done with WA #74

Open
JaviMerino opened this issue Nov 20, 2015 · 1 comment
Assignees

Comments

@JaviMerino
Copy link
Contributor

WA introduces a TRACE_START and TRACE_STOP markers in the trace when doing a run. trappy.wa should learn to get those and, using the abs_window feature of the Run object, limit the trace to that.

Note: Run.normalize_time() should probably need to accept a basetime parameter again.

@JaviMerino JaviMerino self-assigned this Nov 20, 2015
@JaviMerino
Copy link
Contributor Author

The description above could be implemented in a general form as:

trappy.FTrace(path, marker_window=("TRACE_START", "TRACE_STOP"))

However, @derkling suggests to make it a lot more general than this. Instead of having to parse the trace again for every new window of markers that you want to look at, he suggests having an API that allows you to get a window view of the trace out of the full trace. For example, assuming that Phase X start and Phase X stop trace markers were injected in the trace when different phases of a workload start/stop, we could do:

trace = trappy.FTrace(path)
phase1_trace = trace.betweenMarkers("Phase 1 start", "Phase 1 stop")
phase1_trace.sched_switch.data_frame
# Would get a data frame for the sched_switch events that happen only in phase 1

The object returned by betweenMarkers() should have the same interface as that of trappy.FTrace(). For the end user, it should behave exactly the same. Internally, it could be an instance trappy.FTrace or a subclass of it.

betweenMarkers() should renormalize the time by default. We can make that a parameter later if there is demand for it.

valschneider pushed a commit to valschneider/trappy that referenced this issue Sep 28, 2018
ipynb: add Android workloads section for Android-related notebooks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant