Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fixed-width 128-bit SVE implementation #503

Merged
merged 5 commits into from
Sep 11, 2024
Merged

Conversation

solidpixel
Copy link
Contributor

@solidpixel solidpixel commented Sep 5, 2024

This PR adds basic support for a 128-bit SVE implementation, which is implemented as an enhanced version of the NEON SIMD library rather than as a dedicated pure SVE implementation.

Note that the NEON code was added as part of the 256-bit SVE port, so this change is purely build infrastructure to expose the new build type with the correct compiler settings.

On Neoverse V2 performance is 5% better for 4x4 blocks, improving to 10% better for 12x12 blocks. This is 1/3 from compiler-injected code, and 2/3 from using native gathers.

@solidpixel solidpixel added this to the 4.9.0 milestone Sep 5, 2024
Base automatically changed from sve-len-check to main September 10, 2024 16:33
Copy link

@markbarnett-arm markbarnett-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

astcenc_print_header() needs updating. It doesn't cater for ASTCENC_SVE==4 so it'll end up printing simdtype "neon" in the help string.

@solidpixel solidpixel merged commit 631fb04 into main Sep 11, 2024
7 checks passed
@solidpixel solidpixel deleted the sve_128 branch September 11, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants