Move SVE length check to a veneer #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solidpixel
commented
Sep 5, 2024
solidpixel
commented
Sep 5, 2024
solidpixel
force-pushed
the
sve-len-check
branch
from
1f19eb0
to
2afbe48
Compare
markbarnett-arm
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code tries to use an SVE length check to validate that the compile-time length matches the run-time length in the current hardware. However, it appears that the behavior of
svcntw()is to return the compile-time fixed size if used in fixed-size code.This PR moves the validation check into a new veneer that is compiled with SVE, but without a fixed vector length.