Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded print #552

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Remove unneeded print #552

merged 1 commit into from
Nov 13, 2024

Conversation

kevin-thankyou-lin
Copy link
Contributor

What this does

Removes unneeded print

@kevin-thankyou-lin
Copy link
Contributor Author

@youliangtan I removed one print statement to avoid clogging the terminal - could you take a look?

@kevin-thankyou-lin
Copy link
Contributor Author

Oops @youliangtan looks like you don't have write access --- asking @zhuyifengzju to take a look

@zhuyifengzju
Copy link
Contributor

Shall we change it to debug logging messages?

@kevin-thankyou-lin
Copy link
Contributor Author

Looking at the other .debug(), these are only used when there's something unexpected e.g.

                if part_name not in self._action_split_indexes:
                    ROBOSUITE_DEFAULT_LOGGER.debug(f"{part_name} is not specified in the action space")
                    continue

so I think using .debug() mightn't fit? Also, not sure how useful logging this is anyways - we only have this print statement for one file

@kevin-thankyou-lin kevin-thankyou-lin merged commit d44e816 into master Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants